Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font LineHeight 처리, Design System 아이콘, 컬러 추가 #24

Merged
merged 8 commits into from
Jan 30, 2024
Merged

Font LineHeight 처리, Design System 아이콘, 컬러 추가 #24

merged 8 commits into from
Jan 30, 2024

Conversation

WhiteHyun
Copy link
Member

@WhiteHyun WhiteHyun commented Jan 30, 2024 •
edited
Loading

Screenshots 📸

폴더구조 바뀐 컬러 시스템 아이콘 에셋
image image image



고민, 과정, 근거 💬

🔧 Improvements

✏️ Font

  • 각 폰트마다 지정된 높이가 계산되지 않았습니다. 그래서 각 폰트마다 Figma의 Line height에 맞게 적용시켰습니다.
    • FontSetting이라는 설정 객체를 이용하여 UIFont를 생성한 뒤 제공해야할 line height 높이값(Figma)과 함께 동봉하여 폰트의 값을 조절했습니다.
이전 이후 Figma 디자인
image image image
  • Fonts 객체가 폰트 그 자체의 역할을 하는 게 아니므로 이름을 FontRegistrar로 변경했습니다.

🖌️ Color

  • Figma 디자인 컬러 시스템이 일부 변경되어 이를 재적용했습니다.

📷 Icon

  • 55종의 아이콘을 추가하고, 네이밍은 Apple의 SF Symbol을 따랐습니다.

🚜 Remove

돌담 폰트를 제거했습니다.



References 📋

  1. iOS Line Spacing, Line Height
  2. How to set line height for a single line text in SwiftUI?

@WhiteHyun WhiteHyun added 🔧 Enhancement Improvement or Feedback Implementation 🔨 Implementation New feature or request labels Jan 30, 2024
@WhiteHyun WhiteHyun added this to the v2.0.0 milestone Jan 30, 2024
@WhiteHyun WhiteHyun requested a review from a team January 30, 2024 07:37
@WhiteHyun WhiteHyun self-assigned this Jan 30, 2024
eung7
eung7 reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@eung7 eung7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

폰트마다 줄 간격을 바꿔주는 생각은 전혀 하지 못했어요!

Shared/Sources/DesignSystem/Sources/Extensions/Text+Font.swift Outdated Show resolved Hide resolved
@WhiteHyun WhiteHyun requested review from eung7 and a team and removed request for eung7 and a team January 30, 2024 11:43
@WhiteHyun WhiteHyun merged commit 8cff04a into main Jan 30, 2024
2 checks passed
@WhiteHyun WhiteHyun deleted the feature/designsystem/22 branch January 30, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eung7 eung7 eung7 approved these changes

Assignees

@WhiteHyun WhiteHyun

Labels
🔧 Enhancement Improvement or Feedback Implementation 🔨 Implementation New feature or request
Projects
PyeonHaeng iOS Iterative development
Status: Done
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

DesignSystem - Icon, Font, Color 설정
2 participants
@WhiteHyun @eung7