Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module] Log 수정 + Figma 디자인 컬러 수정 부분 변경 #31

Merged
merged 5 commits into from
Feb 2, 2024

Conversation

WhiteHyun
Copy link
Member

@WhiteHyun WhiteHyun commented Feb 1, 2024

Screenshots 📸

수정된 DesignSystem
image



고민, 과정, 근거 💬

⏺️ 로그 수정

/// 로그
public enum Log {
  /// Log를 생성합니다.
  /// - Parameter category: Log를 구분하는 Category
  public static func make(with category: LogCategory) -> Logger? {
    #if DEBUG
      Logger(subsystem: .bundleIdentifier, category: category.rawValue)
    #else
      nil
    #endif
  }
}

기존에는 함수 내부에서 로그를 호출하는 방식이었으나, 실제 로그가 출력된 곳을 따라가면 Log 구현체로 귀결되므로 호출자쪽에서 Logger를 실행하도록 구현했습니다.
대신에, debug가 아닌 release configuration일 때는 Log 자체를 호출하지 않도록하고자 리턴타입을 Logger?로 변경했습니다.

🎨 Design System 수정

  • 디자이너님께서 Figma 색상 컬러가 잘못되었다는 이야기를 전해주셔서 바로 수정 작업했습니다. 동시에 PromotionTagView의 배경색도 변경되었기에, 이를 수정했습니다.
  • 제주돌담 폰트 리소스를 제거했습니다.(분명 제거했는데 왜 살아있을까요? 😂)




- Changed `Log(_:with:at:)` to `Log.make(with:)` with `Logger?` as its return type
- Adjusted views with the name of the modified colors in DesignSystem
- Aligned the background color with the Figma design specifications.
@WhiteHyun WhiteHyun added the 🔧 Enhancement Improvement or Feedback Implementation label Feb 1, 2024
@WhiteHyun WhiteHyun added this to the v2.0.0 milestone Feb 1, 2024
@WhiteHyun WhiteHyun requested a review from a team February 1, 2024 13:42
@WhiteHyun WhiteHyun self-assigned this Feb 1, 2024
@WhiteHyun WhiteHyun linked an issue Feb 1, 2024 that may be closed by this pull request
Copy link
Contributor

@eung7 eung7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 수고하셨습니다!

@WhiteHyun WhiteHyun merged commit 0558b45 into main Feb 2, 2024
2 checks passed
@WhiteHyun WhiteHyun deleted the feature/designsystem/30 branch February 2, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔧 Enhancement Improvement or Feedback Implementation
Projects
Development

Successfully merging this pull request may close these issues.

로그 모듈 수정 및 변경된 디자인 컬러 시스템 적용
2 participants