편의점 바텀시트 구현 #49
Merged
편의점 바텀시트 구현 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a bottom sheet view to display the convenience store selection modal.
eung7
suggested changes
Feb 23, 2024
PyeonHaeng-iOS/Sources/Scenes/HomeScene/BottomSheet/ConvenienceSelectBottomSheetView.swift
Outdated
Show resolved
Hide resolved
- Moved isPresented state variable to HomeProductDetailSelectionView for better state management. - Renamed isPresented variable to convenienceStoreModalPresented for improved clarity and readability.
- Replaced `@Binding` with `@Environment(\.dismiss)` for modal presentation management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots 📸
고민, 과정, 근거 💬
modal로 띄우기 위해
isPresented를 어디에 두어야할까Source of truth를 ViewModel의 state로 한정하려고 했으나, 뷰를 모달로 띄우기 위해선 state를 수정할 권한을 뷰에게 주어야했습니다.저는 state 변경을 View에서 하지 않고 ViewModel에서만 수정할 수 있도록 제한하고 싶어 결국 새로운
Source of truth를 추가했습니다.다른 좋은 방법이 있다면 언제든 피드백 부탁드리겠습니다.. 🙇