Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination API 추가로 인한 모델 변경 / Convenience Store rawValue 변경 #51

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Pagination API 추가로 인한 모델 변경 / Convenience Store rawValue 변경 #51

merged 1 commit into from
Feb 24, 2024

Conversation

WhiteHyun
Copy link
Member

@WhiteHyun WhiteHyun commented Feb 23, 2024 •
edited
Loading

고민, 과정, 근거 💬

  • 페이지네이션 가능하도록 API가 구현되었기에, 제품API 구조를 변경했습니다.
  • Paginated, Paginable를 만들었습니다. Paging만을 담당하는 녀석을 구현하기 위해 protocol로 분리해보았습니다.
  • 7-ElEVEN을 7-ELEVEn로 변경했습니다. -> 백엔드 서버와 맞추기 위함

@WhiteHyun
🚧 Update data models due to API changes
9fa5e34 
- Adjusted data models to align with the updated api structure.
@WhiteHyun WhiteHyun added 🔧 Enhancement Improvement or Feedback Implementation 🛜 Network Networking labels Feb 23, 2024
@WhiteHyun WhiteHyun added this to the v2.0.0 milestone Feb 23, 2024
@WhiteHyun WhiteHyun requested a review from a team February 23, 2024 11:28
@WhiteHyun WhiteHyun self-assigned this Feb 23, 2024
@WhiteHyun WhiteHyun changed the title Pagination API 추가로 인한 모델 변경 Pagination API 추가로 인한 모델 변경 / Convenience Store rawValue 변경 Feb 23, 2024
eung7
eung7 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@eung7 eung7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다. 👍
Paginated라는 모델이 제네릭으로 구현하신 이유가
나중에 Product이외의 다른 모델들도 페이징 처리가 되실 것을 확장성 있게 하시기 위함으로 이해하면 될까요?!

@WhiteHyun
Copy link
Member Author

수고하셨습니다. 👍 Paginated라는 모델이 제네릭으로 구현하신 이유가 나중에 Product이외의 다른 모델들도 페이징 처리가 되실 것을 확장성 있게 하시기 위함으로 이해하면 될까요?!

네 맞습니다. 당장에는 필요 없을 수도 있지만요. 하하

@WhiteHyun WhiteHyun merged commit 56849bc into main Feb 24, 2024
6 checks passed
@WhiteHyun WhiteHyun deleted the feature/home/50 branch February 24, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eung7 eung7 eung7 approved these changes

Assignees

@WhiteHyun WhiteHyun

Labels
🔧 Enhancement Improvement or Feedback Implementation 🛜 Network Networking
Projects
PyeonHaeng iOS Iterative development
Status: Done
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

API 변경으로 인한 Mock JSON 수정
2 participants
@WhiteHyun @eung7