이메일 보내기 기능 #96
Merged
이메일 보내기 기능 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented `MailSheetView` to present a modal view for sending emails upon button press
- Implemented the functionality to send emails directly from the app. If unable to send an email, added code to redirect users to the Mail app store page
- Updated the app to hide images from Accessibility tools to avoid unnecessary distractions. - Added descriptive text for version information
WhiteHyun
added
🔧 Enhancement
- Created DeviceProvider protocol to abstract device-related information for use in composing email bodies. - Modified MailView to rely on DeviceProvider for dynamically populating the mail body with relevant device information, enhancing the detail and relevance of email communications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots 📸
고민, 과정, 근거 💬
편행 1.0 기능을 답습했습니다.
특히 MailView를 구현하는 과정에서 따로 SwiftUI.View를 만들어 사용할 수 있는 방법이 아직 없어서,
UIViewControllerRepresentable를 사용했습니다....
슬슬 각 공지사항의 행마다 하나의 뷰를 만들어줘야겠다는 생각이 듭니다.
점점 SettingsView가 읽기 어려워지고 있네요.
그리고 객체 주입방법도 어떻게 해야하는 게 좋을지 고민이 많이 됩니다 ㅎㅎ..