-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor package info to setup.cfg, run pyupgrade #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some things I saw, unless you want to address them elsewhere?
paste/deploy/loadwsgi.py
Outdated
e.args = tuple(args) | ||
e.message = args[0] | ||
raise | ||
|
||
class InterpolateWrapper(object): | ||
class InterpolateWrapper: | ||
# Python >= 3.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a Python less than 3 branch here somewhere?
I'm on mobile!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, removed that code
@@ -102,7 +102,7 @@ def before_get(self, parser, section, option, value, defaults): | |||
except Exception: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a really yucky way to reraise with a changed exception message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, not going to try to clean it up right now though :-)
version = 2.1.1 | ||
author = Ian Bicking | ||
author_email = [email protected] | ||
maintainer = Chris Dent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dunno, would have to find out if chris is around - going to leave it as is.
No description provided.