Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- update Pyramid Request Processing Diagram. #2490

Merged
merged 2 commits into from
Apr 13, 2016
Merged

- update Pyramid Request Processing Diagram. #2490

merged 2 commits into from
Apr 13, 2016

Conversation

stevepiercy
Copy link
Member

@mmerickel
Copy link
Member

Ah, BeforeTraversal is an event, it goes between blocks similar to ContextFound... it should be on the line between route predicates and traversal.

@mmerickel
Copy link
Member

Also personally I think "csrf check" fits the style better than "CSRF checks". Similarly "url dispatch" instead of "URL dispatch". Those 2 just look weird now! Just one man's opinion though.

@stevepiercy
Copy link
Member Author

Updated placement of BeforeTraversal.

Sorry, I just can't bring myself to lowercase acronyms.

@mmerickel
Copy link
Member

LGTM

@stevepiercy stevepiercy merged commit 3021c2e into Pylons:master Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevepiercy @mmerickel