Update user.py to prevent attribute error in check_password function #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original file is not working with python 3 interpreter. (didn't check with python 2) password_hash is of type bytes, bytes object doesn't have attribute encode. The error is evaded by removing the encoding function.
|
Please see this PR as to why the change was made: #2576 We need to convert this to a |
12 tasks
|
Closing in favor of new issue #2623 |
mmerickel
added a commit
to mmerickel/pyramid
that referenced
this pull request
Jul 16, 2016
Something really weird is happening but this fixes it. SQLAlchemy is returning the "password_hash" from queries as the type that it was inserted as. Not consistently unicode or bytes. If I insert bytes, then I get bytes back out. If I insert unicode then I get unicode back out. It's unclear why, as the type is Text, the data we're storing is unambiguously US-ASCII and the connection is using a consistent text_factory for unicode conversions of "str" on Python 3. Here, we ensure that we always insert the value as unicode which appears to fix downstream issues like those mentioned in Pylons#2605. I was able to reproduce that bug and confirm this fixes it if the original database is initialized using this fix. Obsoletes Pylons#2623.
mmerickel
added a commit
to mmerickel/pyramid
that referenced
this pull request
Jul 16, 2016
Something really weird is happening but this fixes it. SQLAlchemy is returning the "password_hash" from queries as the type that it was inserted as. Not consistently unicode or bytes. If I insert bytes, then I get bytes back out. If I insert unicode then I get unicode back out. It's unclear why, as the type is Text, the data we're storing is unambiguously US-ASCII and the connection is using a consistent text_factory for unicode conversions of "str" on Python 3. Here, we ensure that we always insert the value as unicode which appears to fix downstream issues like those mentioned in Pylons#2605. I was able to reproduce that bug and confirm this fixes it if the original database is initialized using this fix. Obsoletes Pylons#2623.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original file is throwing Attribute Error in check_password function with python 3 interpreter. (didn't check with python 2)
password_hash is of type bytes, bytes object doesn't have attribute encode.
The error is evaded by removing the encoding function.