Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with Pyramid 1.8 #23

Merged
merged 2 commits into from
Apr 3, 2017
Merged

Conversation

fschulze
Copy link
Contributor

This fixes #22, but there are 4 more test failures about derived_views which I don't understand yet.

@mmerickel
Copy link
Member

Previously those views were registered for both IViewClassifier and IExceptionViewClassifier. In Pyramid 1.8 they are registered only for IExceptionViewClassifier so probably the test should just be switched to that.

I noticed one other thing which is that Pylons/pyramid#2757 dropped pyramid.config.expand_action because I had no idea anyone was using it but it's apparently quite heavily used throughout the tests. Since 1.8 this line will never work:

from pyramid.config import expand_action
No good recommendation here but I'd rather not bring it back into Pyramid...

@fschulze
Copy link
Contributor Author

I've switched to use IExceptionViewClassifier. This also works with older Pyramid versions. I have a branch where I added environments for testing that. Not sure you want that merged, because it isn't integrated with Travis and there is a PR open that changes Travis/tox stuff.

It seems like the fallback import from zope.configuration.config import expand_action works fine, so I don't see a need for action there.

Python 2.6 fails with Pyramid 1.8, but works with older Pyramid versions.

PyPy3 currently fails, because virtualenv or pip is incompatible with it, because it's currently only supporting Python 3.2.

@fschulze fschulze changed the title Partly fix compatibility with Pyramid 1.8 Fix compatibility with Pyramid 1.8 Jan 24, 2017
@stevepiercy
Copy link
Member

FWIW Python 2.6 support was dropped in Pyramid 1.7, and we dropped PyPy3 support until it supports Python 3.4+. We dropped Python 3.2 in Pyramid 1.7, and Python 3.3 in Pyramid 1.8.

Pyramid 1.8 is tested and supported on Python 2.7, Python 3.4, Python 3.5, Python 3.6, and PyPy.

@fschulze
Copy link
Contributor Author

I have a branch now that tests everything with travis: https://github.com/fschulze/pyramid_zcml/tree/tox-travis

@mmerickel
Copy link
Member

Yep this all looks as expected. Thanks @fschulze. @mcdonc is the only one with access to pypi so he'll need to cut a new release or give someone access (you?) to do it.

@mmerickel
Copy link
Member

mmerickel commented Apr 3, 2017

@fschulze Apparently I ended up with pypi ownership so I've given you pypi access if you wish to cut a release of pyramid_zcml. You are also now an admin on this repo if you wish to manage merge requests.

@fschulze fschulze merged commit af63486 into Pylons:master Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError in pyramid_zcml with pyramid 1.8.0
3 participants