On Windows IPPROTO_IPV6 may not be defined in socket #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately due to some reshuffling of headers on Windows, and Python defining the wrong Windows version, IPPROTO_IPV6 may not be defined on Windows. If this is the case, we set them to some magic values. If there is an OS out there that doesn't define those flags, and they are not windows, we raise a RuntimeError because we need to add some magic variables, waitress requires IPv6...
We can't use service names instead of port numbers on Windows, so attempt to turn the port into an integer. If unable to do so, raise an error.
However Python 3 apparently does, since we have a test for this, and upon changing things tests started failing on Python 3 on Windows.
Disable IPv6 support if there is no IPv6 support on the platform
digitalresistor
force-pushed
the
bugfix/socket_flags_windows
branch
from
349a43b to
57ea838
Compare
|
Pulled PR #141 into this one. |
mmerickel
approved these changes
Oct 14, 2016
|
That's the numbers for those constants defined in winsock. Going to spin up a windows VM and test it later. |
|
I've tried this patch and the issues I had are fixed with it. |
|
Excellent. I'll spin a new release today with this patchset. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately due to some reshuffling of headers on Windows, and Python
defining the wrong Windows version, IPPROTO_IPV6 may not be defined on
Windows. If this is the case, we set them to some magic values.
If there is an OS out there that doesn't define those flags, and they
are not windows, we raise a RuntimeError because we need to add some
magic variables, waitress requires IPv6...
Closes #138, #139