GDPopt solver prototype #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… adding mapping from transformed constraints back to originals, and adding tests in bigm where there are multiple constraints on a disjunct
…things (dict comprehension)
The user can specify any combination of descend_into and ctypes. If you descend into things other than just Block, then you also need to generate teh ciuds for those components.
This transformation will reclassify all Disjuncts as Blocks so that the current writers can locate the indicator_vars.
Disjunction `expr` can return a list of Disjuncts or relational expressions. THe latter means that for simple Disjunctions (that only contain a single expression in the Disjunct) the user does not need to go through the process of explicitly declaring the Disjunct blocks.
…s tests of tiny example to convex hull
…at don't exist, don't descend into disjuncts)
Allow NLP presolve callback hook. Allow specification of stall_after Modify OA cut generation
Add reporting of number of OA cuts added. Fix implementation of ignore_set for OA cuts.
|
Almost all of the other PRs referenced in the original comment have been merged or closed. @qtothec does is make sense to close this PR and open a new one containing only the changes that have not already been merged? It is going to be really hard to review this PR as is. |
|
@blnicho Yes. There's also been a number of conflicts that have needed to be resolved, which have been done on my dev branch, but aren't organized in a coherent way here. I will close and re-open a new PR when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the omnibus PR that I told @jsiirola about on Thurs. Aug 31. It subsumes several other PRs, including #196, #192, #190, #176, #169, and #166.