Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifies the backend interface (use available classes!) #206

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

nielstron
Copy link
Contributor

This is a minimal effort change to the backends to leverage the available classes in PyCardano for user-friendliness

In particular, if a class for something is available then the backend should support it

This is a minimal effort change to the backends to leverage the
available classes in PyCardano for user-friendliness

In particular, if a class for something is available then the backend
should support it
@codecov-commenter
Copy link

Codecov Report

Merging #206 (153f671) into main (090879e) will increase coverage by 0.00%.
The diff coverage is 90.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   85.59%   85.59%           
=======================================
  Files          26       26           
  Lines        2846     2853    +7     
  Branches      677      677           
=======================================
+ Hits         2436     2442    +6     
- Misses        303      304    +1     
  Partials      107      107           
Impacted Files Coverage Δ
pycardano/txbuilder.py 90.15% <66.66%> (ø)
pycardano/backend/base.py 98.63% <90.90%> (-1.37%) ⬇️
pycardano/backend/blockfrost.py 31.49% <100.00%> (ø)
pycardano/backend/ogmios.py 58.84% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nielstron
Copy link
Contributor Author

As you can see from the code changes, the number of occurrences where the code is called with cbor instead of a Transaction object is actually 0. Almost the same for addresses.

Copy link
Collaborator

@cffls cffls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. This is a breaking change. Will include it in v0.9.

@cffls cffls merged commit 95881a0 into Python-Cardano:main Apr 15, 2023
@cffls cffls added the enhancement New feature or request label Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants