-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting attributes on <ol> and <ul> tags with attr_list extension #1252
Conversation
values set on list items to their parent list element. This allows list-wide attributes, such as start number or class to be set.
I'm not commenting on whether this feature should or should not be included, but how would you specify both a class on an |
As mentioned in the doc update this isn't possible with this patch. I initially started out with a |
An alternative could be to have a single ^ as a marker in the attribute list to indicate that all attributes following it should be set on the parent. That would allow both list and table attributes with minimal code changes. |
as a marker to indicate all attributes following it should be lifted to the parent. This allows one to set attributes on a list item, while also setting attributes on the parent.
I updated the pull request to use |
As I have stated on every request we have received for this, we will not be implementing this feature. Of course, you are free to provide this functionality in a third party extension. |
I have seen a number of similar comments about not wanting to implement it, but I'm really struggling to understand why? This feature is currently not available, yet is obviously valuable to many, given all the requests over the many years it has shown up as an issue here. The way I implement it here does not seem to interfere with any existing feature, as far as I can tell. And if the special Please help me understand, because this all does not make any sense... |
This has been discussed and explained many times over. You even linked to some of those discussions. In short, I am not interested in supporting a syntax that is does not make sense to me. It should be no surprise that it was rejected. Of course, you are free to disagree with me on this. If this is important to you, then you can provide and support your own third-party extension which provides the feature. |
From me as an outside-viewer I can see this response as essentially "I don't like this, so I don't want it" response. |
I don't accept things that I'm not willing to support long term. Long after the person who proposes it is gone, I'm left defending it and fixing issues with it. That's (one of the reasons) why we provide a public extension API. Anyone can provide their own implementation which works how they want. Then they can support it without any additional burden on me. I am not limiting anyone at all except for myself. |
This adds a way for the attr_list extension to lift attribute values set on list items to their parent list element (i.e.
<li>
attribute to<ul>
or<ol>
). This allows list-wide attributes, such as list start number or class to be set by setting them on list items with the appropriate syntax.Contains additions to the docs describing it, as well extra test input (plus all existing unit tests still pass)
Should be able to solve #227, #668 and many of the other requests for a similar feature, including my own quest to get this feature.