Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow saving merged segments to all formats #495

Merged
merged 3 commits into from
Apr 23, 2024
Merged

allow saving merged segments to all formats #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a67e64e
allow saving merged segments to all formats
fedorov Apr 22, 2024
c782574
update python to 3.10.11
fedorov Apr 23, 2024
c0bef7a
remove incorrect statement re 4D NRRD output
fedorov Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cmake-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
fetch-tags: true
- uses: actions/setup-python@v4
with:
python-version: '3.7.14'
python-version: '3.10.11'

# Install build tools (cmake and ninja) as well as jsondiff
- name: "Install jsondiff"
Expand Down Expand Up @@ -119,4 +119,4 @@ jobs:
--prerelease-packages ${{ github.workspace }}/dcmqi-build/dcmqi-build/dcmqi-*-mac-*.tar.gz \
--prerelease-packages-clear-pattern "dcmqi-*-mac-*" \
--prerelease-packages-keep-pattern "*<COMMIT_DATE>-<COMMIT_SHORT_SHA>*" \
--exit-success-if-missing-token --token ${{ secrets.GA_TOKEN }}
--exit-success-if-missing-token --token ${{ secrets.GA_TOKEN }}
5 changes: 0 additions & 5 deletions apps/seg/segimage2itkimage.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,6 @@ int main(int argc, char *argv[])
dcmtk::log4cplus::BasicConfigurator::doConfigure();
}

if (mergeSegments && outputType != "nrrd") {
std::cerr << "ERROR: mergeSegments option is only supported when output format is NRRD!" << std::endl;
return EXIT_FAILURE;
}

if(helper::isUndefinedOrPathDoesNotExist(inputSEGFileName, "Input DICOM file")
|| helper::isUndefinedOrPathDoesNotExist(outputDirName, "Output directory"))
return EXIT_FAILURE;
Expand Down
2 changes: 1 addition & 1 deletion apps/seg/segimage2itkimage.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
<channel>input</channel>
<longflag>mergeSegments</longflag>
<default>false</default>
<description>Save all segments into a single file. When segments are non-overlapping, output is a single 3D file. If overlapping, single 4D following conventions of 3D Slicer segmentations format. Only supported when the output is NRRD for now.</description>
<description>Save all segments into a single file. When segments are non-overlapping, output is a single 3D file. If overlapping segments are identified, multiple 3D files will be created each containing non-overlapping segments. Metadata JSON files will be created for each such 3D file.</description>
</boolean>

</parameters>
Expand Down
Loading