-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language is not being applied correctly #941
Comments
It reads and matches your UI language. |
I think there's a bug in finding a translation: https://github.com/QL-Win/QuickLook.Common/blob/master/Helpers/TranslationHelper.cs#L56 Do you have developing exp to test this fix? If not I'll find some time tod test it. |
I'm starting at coding but tell me what to do & I'll try |
Nevermind, I got some time to debug. |
i have msi version but i dont see any QuickLook.Common.dll file in app dir |
It's located aside QuickLook.exe. |
i replaced it but now QuickLook doesn't starts. I tried rebooting OS but nothing |
Got it. I'll give you are full test package tomorrow. |
Try this one: |
If you right click on the tray icon, what language is the menu in? |
Spanish!! |
So it's correct now, whereas in the release version you see English? |
yes it's showing text correctly |
I don't get it. What is your issue then? |
The QL languague keeps in English. With the files you sent me the app shows texts in OS lang (es) but only when I right click on tray icon (#941 (comment)) and QL doesnt work anymore, just shows the message boxes. |
the issue is that QL is not recognizing the language and there's no manual way to select it neither |
Do you mean: with QuickLookUITest.zip you see the context menu in Spanish, but with the official release the same context menu is in English? |
Exactly |
Ok so your issue is fixed if you use the latest zip file, right? |
Look, WITH QuickLookUITest.zip tray icon options are displayed in my language BUT when I try to use QL to see files preview it shows this boxes (#941 (comment)) so idk if the strings of file previews are showing translated WITHOUT QuickLookUITest.zip all the strings (in previews and tray icon) are always in English (i use Spanish) |
https://ci.appveyor.com/project/xupefei/quicklook/builds/39767002/artifacts should fix your issue. Please try and report back! |
My OS language is set on Spanish (es) but app keeps showing all texts in English and there isn't any manual way to change it (at least i didn't find it and repo doesn't says anything about it)
The text was updated successfully, but these errors were encountered: