-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add fetch service list and get service detail from k8s cluster api to backend #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilhelmguo
reviewed
Dec 21, 2018
wilhelmguo
approved these changes
Dec 24, 2018
LGTM @chengyumeng Please review the PR. |
chengyumeng
reviewed
Dec 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文件不应该放在这个目录下面
chengyumeng
reviewed
Dec 24, 2018
@chengyumeng @HZ89 还有其他问题吗 |
我没啥问题 |
之前 review 提出的问题有一些还没回复呀 @HZ89 @wilhelmguo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/feature
Categorizes issue or PR as related to a new feature.
sig/backend
Categorizes an issue or PR as relevant to sig-backend.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
api add:
test result:
curl --location --request GET "http://127.0.0.1:8080/api/v1//kubernetes/apps/0/services/namespaces/default/clusters/minikube"
curl --location --request GET "http://127.0.0.1:8080/api/v1//kubernetes/apps/0/services/my-nginx/detail/namespaces/default/clusters/minikube"