Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secret save error when contain chinese character #203

Merged

Conversation

BennieMeng
Copy link
Collaborator

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind bug

What this PR does / why we need it:
secret save chinese lead to error

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #193

@BennieMeng BennieMeng requested a review from wilhelmguo January 7, 2019 08:01
@wilhelmguo wilhelmguo added the kind/bug Categorizes issue or PR as related to a bug. label Jan 9, 2019
@wilhelmguo wilhelmguo merged commit a9dc255 into Qihoo360:master Jan 9, 2019
@BennieMeng BennieMeng deleted the feature/secret-chinese-support branch August 28, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is a js error when secret contains chinese character
2 participants