-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
添加创建部署资源单位,样式调整 #27
Merged
chengyumeng
merged 3 commits into
Qihoo360:master
from
BennieMeng:feature/resource-unit-add
Nov 20, 2018
Merged
添加创建部署资源单位,样式调整 #27
chengyumeng
merged 3 commits into
Qihoo360:master
from
BennieMeng:feature/resource-unit-add
Nov 20, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/lgtm @chengyumeng |
wilhelmguo
approved these changes
Nov 20, 2018
[(ngModel)]="resourcesMetas.memoryLimit" | ||
#memoryLimit="ngModel"> | ||
<span class="tooltip-content"> | ||
请填写内存限制份数. | ||
</span> | ||
</label> | ||
<div class="percent-label">Gi</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个直接写成G
chengyumeng
reviewed
Nov 20, 2018
@@ -103,14 +105,16 @@ <h3 class="modal-title">{{title}}</h3> | |||
<input type="text" id="memoryLimit" placeholder="内存限制" | |||
type="number" | |||
name="memoryLimit" | |||
style="width: 110px;" | |||
[(ngModel)]="resourcesMetas.memoryLimit" | |||
#memoryLimit="ngModel"> | |||
<span class="tooltip-content"> | |||
请填写内存限制份数. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“份数”这种可以改成不那么口语化 #TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/enhancement
Categorizes issue or PR as related to enhancement.
sig/frontend
Categorizes an issue or PR as relevant to sig-frontend.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
创建部署资源单位, label 样式调整。