Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format notebooks with Ruff #2199

Merged
merged 4 commits into from
Nov 4, 2024
Merged

Format notebooks with Ruff #2199

merged 4 commits into from
Nov 4, 2024

Conversation

frankharkins
Copy link
Member

@frankharkins frankharkins commented Oct 29, 2024

Follow-up to #2197. Draft until that PR is merged, then I'll rebase this.

Also a partial fix for #1806 depending if we want to also lint code examples in MDX.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1 @@
line-length=78
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the longest length that doesn't scroll horizontally on the website. I tested by inspect element then adding characters until the box scrolled on Firefox.

@frankharkins frankharkins marked this pull request as ready for review October 29, 2024 14:24
@qiskit-bot
Copy link
Contributor

One or more of the following people are relevant to this code:

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

I forgot to mention, can you please check that the README is up to date?

Copy link
Contributor

@ThomasMerkh ThomasMerkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@frankharkins
Copy link
Member Author

Gonna wait to merge this until after #2139 is merged to avoid further disruption.

@frankharkins frankharkins added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 9d98cb0 Nov 4, 2024
4 checks passed
@frankharkins frankharkins deleted the FH/ruff-format branch November 4, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants