Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin qiskit < 1.0 #464

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Pin qiskit < 1.0 #464

merged 1 commit into from
Dec 13, 2023

Conversation

garrison
Copy link
Member

@garrison garrison commented Dec 10, 2023

The Qiskit 0.45 release notes say:

If your project depends on Qiskit, it may rely on functionality that will no longer be supported in Qiskit 1.0. For this reason, we recommend that you proactively cap your supported version to <1.0.

This PR proactively pins the version to < 1.0, as suggested. Once nice thing about this is that is relieves a bit of pressure for us to fix issue #406 before Qiskit 1.0 is released on Jan 31. Also, if we are ready to support Qiskit 1.0 on that date, we can issue a patchlevel release easily that updates the pin to < 2.0.

I've gone ahead and added a development version CI run against qiskit's stable/0.46 branch too, to essentially guarantee that there are no surprises when that is released.

Updated README badges are visible at https://github.com/Qiskit-Extensions/circuit-knitting-toolbox/blob/pin-qiskit-0.X/README.md.

@garrison garrison added the dependencies Pull requests that update a dependency file label Dec 10, 2023
@garrison garrison marked this pull request as ready for review December 10, 2023 02:57
Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks! I'm curious to see what breaks, if anything, when we test against 1.0

@garrison garrison merged commit 8ceb806 into main Dec 13, 2023
10 checks passed
@garrison garrison deleted the pin-qiskit-0.X branch December 13, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants