Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on ARM macOS runners #560

Merged
merged 3 commits into from
May 16, 2024
Merged

Test on ARM macOS runners #560

merged 3 commits into from
May 16, 2024

Conversation

garrison
Copy link
Member

@garrison garrison commented Apr 24, 2024

This is due to python 3.8 no longer being available on the macos-latest CI runner.

This also allows us to now perform CI on ARM chips on macOS.

This also restores the ubuntu minimum version to 3.8 so that we test on 3.8 somewhere. #515 (comment)

We might see intermittent CI failures again until #556 is merged (expected to be very soon).

This is due to python 3.8 no longer being available on the macos-latest CI runner.

This also restores the ubuntu minimum version to 3.8 so that we test on 3.8 somewhere.
#515 (comment)

We might see intermittent CI failures again until #556 is merged (expected to be very soon).
@garrison garrison added the cicd Related to the CICD pipeline label Apr 24, 2024
@coveralls
Copy link

coveralls commented Apr 24, 2024

Pull Request Test Coverage Report for Build 8825682963

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 95.484%

Totals Coverage Status
Change from base Build 8819948894: 0.05%
Covered Lines: 3489
Relevant Lines: 3654

💛 - Coveralls

@garrison garrison added the on hold Let's wait for something before merging label Apr 24, 2024
@garrison
Copy link
Member Author

garrison commented Apr 24, 2024

I merged #561, which is an alternative to this.

If we want to take this route, we will have to disable the cutqc tests when cplex is not available. This should be fine, since cutqc is deprecated now anyway.

I will fix up this PR to do that when I get a chance, so that we can go back to using the macos-latest runner.

@garrison garrison changed the title Bump macos-latest python version Disable cutqc tests when cplex is not available Apr 24, 2024
@garrison garrison added tests Related to tests cutqc Related to the wire cutting code based on the CutQC paper, arXiv:2012.02333 labels Apr 24, 2024
@garrison garrison changed the title Disable cutqc tests when cplex is not available Disable cutqc notebook tests when cplex is not available Apr 25, 2024
@garrison garrison removed the tests Related to tests label Apr 25, 2024
use python 3.12 on macos, because then we will skip cplex
@garrison garrison changed the title Disable cutqc notebook tests when cplex is not available Test on ARM macOS runners Apr 25, 2024
@garrison
Copy link
Member Author

garrison commented Apr 25, 2024

This is related to Qiskit/qiskit#12102. We might want to wait on that before merging. But otherwise this is all done.

@garrison garrison removed the cutqc Related to the wire cutting code based on the CutQC paper, arXiv:2012.02333 label Apr 25, 2024
@garrison garrison marked this pull request as ready for review April 25, 2024 15:56
@garrison garrison removed the on hold Let's wait for something before merging label May 1, 2024
@garrison
Copy link
Member Author

garrison commented May 1, 2024

Qiskit/qiskit#12102 is now merged. If testing on ARM causes us any intermittent problems before Qiskit 1.1 is released (I don't expect it to), then I can make a follow-up PR so that ARM testing uses qiskit main or stable/1.1 until qiskit 1.1 is released.

@garrison garrison requested a review from caleb-johnson May 1, 2024 00:15
@garrison
Copy link
Member Author

Merging this since Qiskit 1.1 will be released tomorrow.

@garrison garrison merged commit c468735 into main May 16, 2024
11 checks passed
@garrison garrison deleted the garrison-patch-1 branch May 16, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd Related to the CICD pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants