MPS: Apply kraus #915
Merged
MPS: Apply kraus #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce, before the loop over all kraus matrices
chriseclectic
suggested changes
Sep 8, 2020
src/simulators/matrix_product_state/matrix_product_state_internal.cpp
Outdated
Show resolved
Hide resolved
src/simulators/matrix_product_state/matrix_product_state_internal.cpp
Outdated
Show resolved
Hide resolved
|
|
||
| // it is more efficient to compute the density matrix once rather than computing | ||
| // the expectation value in every iteration of the loop | ||
| cmatrix_t rho = qreg_.density_matrix(qubits); |
There was a problem hiding this comment.
Unrelated to this PR, but if MPS supports computing the density matrix, we should add density matrix snapshot support to the class like we do for the statevector method.
There was a problem hiding this comment.
This could also help with testing Kraus noise is being applied correctly
There was a problem hiding this comment.
I will open a separate PR to support snapshot_density_matrix in MPS.
chriseclectic
previously approved these changes
Sep 9, 2020
|
@merav-aharoni I forgot to add: can you add a short release note? |
chriseclectic
added
the
Changelog: New Feature
|
Sure, will do. |
|
@chriseclectic, please do not merge yet - I think I discovered a problem in the implementation. |
|
@merav-aharoni when you add the release note make sure you include a bullet point for the snapshot too. |
chriseclectic
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments