-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't store circuit params automatically #1010
Conversation
Pull Request Test Coverage Report for Build 5954209661
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Two questions just for my understanding -
- Why did you add the
kwargs
parameter and not keepparams
or simply remove both?
And why not remove theparams
in the creation of theRuntimeJob
inQiskitRuntimeService
? - Why did you modify the
SerializableClass.__eq__
method?
releasenotes/notes/dont-store-circuit-params-9d87ffefc2a7d257.yaml
Outdated
Show resolved
Hide resolved
You are right, removing |
Summary
Details and comments
Fixes #987