Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Q-CTRL support #1017

Merged
merged 8 commits into from
Aug 28, 2023
Merged

Q-CTRL support #1017

merged 8 commits into from
Aug 28, 2023

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Aug 14, 2023

Summary

Details and comments

Fixes #964

@coveralls
Copy link

coveralls commented Aug 15, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6002417340

  • 12 of 14 (85.71%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 74.04%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/api/rest/runtime.py 0 2 0.0%
Totals Coverage Status
Change from base Build 6001929505: 0.05%
Covered Lines: 2467
Relevant Lines: 3332
💛 - Coveralls

@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label Aug 21, 2023
@eginez eginez mentioned this pull request Aug 21, 2023
Merged
@kt474 kt474 marked this pull request as ready for review August 24, 2023 21:50
rathishcholarajan
rathishcholarajan approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be good to add integration tests in a follow up PR and merge it only when everything is working on server side

@kt474 kt474 mentioned this pull request Aug 25, 2023
Closed
@kt474
Copy link
Member Author

kt474 commented Aug 25, 2023

LGTM, it would be good to add integration tests in a follow up PR and merge it only when everything is working on server side

Created an issue to follow up: #1017

merav-aharoni
merav-aharoni approved these changes Aug 27, 2023
View reviewed changes
Copy link
Contributor

@merav-aharoni merav-aharoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine. I left a few comments, but most are a matter of opinion, so it is up to you to decide.

qiskit_ibm_runtime/qiskit_runtime_service.py Show resolved Hide resolved
qiskit_ibm_runtime/qiskit_runtime_service.py Show resolved Hide resolved
qiskit_ibm_runtime/qiskit_runtime_service.py Show resolved Hide resolved
test/unit/test_account.py Show resolved Hide resolved
qiskit_ibm_runtime/accounts/account.py Show resolved Hide resolved
qiskit_ibm_runtime/accounts/management.py Show resolved Hide resolved
@kt474
Copy link
Member Author

kt474 commented Aug 28, 2023

Going to merge this for now to unblock the q-ctrl team, we can take care of minor specifics/enhancements in a separate PR

@kt474 kt474 merged commit 22654cb into Qiskit:main Aug 28, 2023
@kt474 kt474 deleted the q-ctrl branch August 28, 2023 18:17
@kt474 kt474 mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merav-aharoni merav-aharoni merav-aharoni approved these changes

@rathishcholarajan rathishcholarajan rathishcholarajan approved these changes

Assignees
No one assigned
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Q-CTRL
4 participants
@kt474 @coveralls @rathishcholarajan @merav-aharoni