Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor todos #1112

Merged
merged 1 commit into from
Sep 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion qiskit_ibm_runtime/estimator.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
from qiskit.quantum_info.operators.base_operator import BaseOperator
from qiskit.primitives import BaseEstimator

# TODO import _circuit_key from terra once 0.23 is released
from .runtime_job import RuntimeJob
from .ibm_backend import IBMBackend
from .options import Options
Expand Down
9 changes: 0 additions & 9 deletions qiskit_ibm_runtime/qiskit_runtime_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -970,15 +970,6 @@ def run(
RuntimeProgramNotFound: If the program cannot be found.
IBMRuntimeError: An error occurred running the program.
"""
# TODO: Remove this after 3 months
if program_id in ["hello-world", "vqe", "qaoa"]:
raise IBMInputValueError(
"The hello-world, vqe, and qaoa programs have been retired in the "
"Qiskit Runtime service. Please visit https://qiskit.org/ecosystem/ibm-runtime "
"for an introduction on Sessions and Primitives, and to access "
"tutorials on how to execute VQE and QAOA using Qiskit Runtime Primitives."
)

qrt_options: RuntimeOptions = options
if options is None:
qrt_options = RuntimeOptions()
Expand Down
2 changes: 1 addition & 1 deletion test/integration/test_backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def test_backend_properties(self):
properties_today = backend.properties(datetime=datetime.today())
self.assertIsNotNone(properties)
self.assertIsNotNone(properties_today)
self.assertEqual(properties, properties_today)
self.assertEqual(properties.backend_version, properties_today.backend_version)

@production_only
def test_backend_pulse_defaults(self):
Expand Down
1 change: 0 additions & 1 deletion test/unit/test_logger.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ def test_valid_log_levels_mixed_casing(self):
"be {}.".format(logger.level, level_value),
)

# TODO: NamedTemporaryFiles do not support name in Windows
@skipIf(os.name == "nt", "Test not supported in Windows")
def test_log_file(self):
"""Test setting up a logger by specifying a file and log level."""
Expand Down
3 changes: 1 addition & 2 deletions test/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,7 @@ def wait_for_status(job, status, poll_time=1, time_out=20):
def get_real_device(service):
"""Get a real device for the service."""
try:
# TODO: Remove filters when ibmq_berlin is removed
return service.least_busy(simulator=False, filters=lambda b: b.name != "ibmq_berlin").name
return service.least_busy(simulator=False).name
except QiskitBackendNotFoundError:
raise unittest.SkipTest("No real device") # cloud has no real device

Expand Down