Skip to content

Commit

Permalink
feat: remove result from list endpoint
Browse files Browse the repository at this point in the history
  • Loading branch information
paaragon committed Jan 30, 2025
1 parent 6a9e66e commit 22d37b5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 13 deletions.
4 changes: 2 additions & 2 deletions gateway/api/views/jobs.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,10 @@ def list(self, request):

page = self.paginate_queryset(queryset)
if page is not None:
serializer = self.get_serializer(page, many=True)
serializer = self.get_serializer_job_without_result(page, many=True)
return self.get_paginated_response(serializer.data)

serializer = self.get_serializer(queryset, many=True)
serializer = self.get_serializer_job_without_result(queryset, many=True)
return Response(serializer.data)

@action(methods=["POST"], detail=True)
Expand Down
13 changes: 2 additions & 11 deletions gateway/tests/api/test_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def test_job_list(self):
jobs_response.data.get("results")[0].get("status"), "SUCCEEDED"
)
self.assertEqual(
jobs_response.data.get("results")[0].get("result"), '{"somekey":1}'
jobs_response.data.get("results")[0].get("result"), None
)

def test_job_catalog_list(self):
Expand All @@ -51,7 +51,7 @@ def test_job_catalog_list(self):
self.assertEqual(jobs_response.data.get("count"), 1)
self.assertEqual(jobs_response.data.get("results")[0].get("status"), "QUEUED")
self.assertEqual(
jobs_response.data.get("results")[0].get("result"), '{"somekey":1}'
jobs_response.data.get("results")[0].get("result"), None
)

def test_job_serverless_list(self):
Expand All @@ -63,15 +63,6 @@ def test_job_serverless_list(self):
)
self.assertEqual(jobs_response.status_code, status.HTTP_200_OK)
self.assertEqual(jobs_response.data.get("count"), 2)
job_status = jobs_response.data.get("results")[0].get("status")
if job_status == "SUCCEEDED":
self.assertEqual(
jobs_response.data.get("results")[0].get("result"), '{"somekey":1}'
)
elif job_status == "QUEUED":
self.assertEqual(
jobs_response.data.get("results")[0].get("result"), '{"somekey":2}'
)

def test_job_detail(self):
"""Tests job detail authorized."""
Expand Down

0 comments on commit 22d37b5

Please sign in to comment.