Add keycloak for Authorization with default configuration #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Tansito
reviewed
Jan 30, 2023
There was a problem hiding this comment.
Thanks @akihikokuroda ! We usually add in helm's README a link to the documentation for the different values that a user can configure too (something similar to what we have for Redis and Nginx in this case is more than enough).
|
@Tansito Thanks for review. I'll update. |
akihikokuroda
force-pushed
the
keycloak
branch
from
fcbe056 to
2ab715b
Compare
Tansito
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fix #136
Adding keycloak dependency in the quantumserverless helm chart for preparation of authorization implementation.
Details and comments
Keycloak is installed with quantumserverless helm install. It has still the default configuration. The configuration will be updated when the OIDC proxy is put into the ray head node.