Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client: execution graphs tracing using opentelemetry #146

Merged
merged 7 commits into from
Feb 2, 2023

Conversation

IceKhan13
Copy link
Member

@IceKhan13 IceKhan13 commented Jan 30, 2023

Summary

Client: execution graphs tracing using opentelemetry.

This PR introduces tracing of all execution workflows.

In order to enable tracing user need to provide env variable OT_JAEGER_HOST_KEY to ray node.

Programs and separate remote functions are traced.

Details

Screen shot of traced benchmark program.

Screen Shot 2023-02-02 at 1 48 15 PM

Resource requirements and (width, depth) of quantum circuits passed are logged into trace info.

Screen Shot 2023-02-02 at 1 49 33 PM

Closes #149

@IceKhan13 IceKhan13 added the enhancement New feature or request label Jan 30, 2023
@IceKhan13 IceKhan13 added this to the 0.2 milestone Jan 30, 2023
@IceKhan13 IceKhan13 marked this pull request as ready for review February 2, 2023 20:40
@IceKhan13 IceKhan13 requested review from pacomf and Tansito February 2, 2023 20:40
Copy link
Member

@pacomf pacomf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Can we add some documentation about requirements to install if someone wants to install the external services without use docker-compose? (redis, jaeger, etc.)

@IceKhan13
Copy link
Member Author

Added and tracked in separate issue #160

@IceKhan13 IceKhan13 merged commit 72b2975 into main Feb 2, 2023
@IceKhan13 IceKhan13 deleted the chore/execution-graph-with-open-telemetry branch February 2, 2023 20:57
@IceKhan13 IceKhan13 self-assigned this Feb 2, 2023
@Tansito
Copy link
Member

Tansito commented Feb 3, 2023

@IceKhan13 sorry that I couldn't check this on time. I assume that we need to modify the configuration for infrastructure too. Can you create me an issue for that? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execution graph tracing and metrics
3 participants