Refactor: integration tests #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The good thing @korgan00 is that for me, locally, all the tests are working. So as we were assuming probably something related with your computer. There are some problems with a couple of tests I think due to permissions. I will try to take a look these days and let you know but awesome work here ❤️ 
|
Tansito
requested changes
Dec 3, 2024
There was a problem hiding this comment.
Four things for the PR, @korgan00:
- Thanks to the refactor now I think we can remove the action that it was running manually the tests: docker-build.yaml
- If I pass the tests locally an archive is created under
tests/with the formatdownloaded_*.tar. I propose to add that pattern to the.gitignoreto avoid push those files.
I think next two can be managed in another PR:
- It would be nice if we can refactor too the action for LocalClient as we commented in the internal issue.
06_function.pyis not being tested. This is normal because it was not being tested before either but the preparation can be a bit different. Let's connect Monday and I can give you some guidance around it.
Overall, awesome job here again, @korgan00. It looks awesome!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details and comments