Feat/remove result from list endpoint #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tansito
reviewed
Jan 31, 2025
| @@ -145,10 +145,10 @@ def list(self, request): | |||
|
|
|||
| page = self.paginate_queryset(queryset) | |||
There was a problem hiding this comment.
@paaragon let's use this opportunity to migrate the queryset too. The idea as we commented is to put all the logic related with the ORM in the Repositories. In this case the philosophy would be similar to what we did in the list for functions: https://github.ibm.com/IBM-Q-Software/qiskit-serverless/blob/main/gateway/api/views/programs.py#L104
Tansito
reviewed
Feb 5, 2025
There was a problem hiding this comment.
Thanks for the refactor @paaragon ! We couldn't remove the get_queryset but for another chance.
As my last comment before merge I think we can remove the method filter_queryset, we are not using it from what I know. With that I think we are going to be able to merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the result from the response in the list endpoint
Details and comments