Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 94 | Client: deprecate __enter__ in favor of context #165

Merged
merged 3 commits into from
Feb 14, 2023

Conversation

IceKhan13
Copy link
Member

@IceKhan13 IceKhan13 commented Feb 3, 2023

Summary

Client: deprecate enter in favor of context

Details and comments

Following code creates a call to len(context)

with serverless:
    ...

which is raising deprecation warning form ray.

For user clearence we will use

serverless.context()
...
# or
with serverless.context():
    ...

to create context inside programs

Closes #94

@IceKhan13 IceKhan13 added the bug Something isn't working label Feb 3, 2023
@IceKhan13 IceKhan13 requested review from pacomf and Tansito February 14, 2023 18:11
@IceKhan13 IceKhan13 marked this pull request as ready for review February 14, 2023 18:11
@IceKhan13 IceKhan13 merged commit 8899919 into main Feb 14, 2023
@IceKhan13 IceKhan13 deleted the issue-94/client-context-deprecation branch February 14, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated context usage
2 participants