Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved repository code quality #320

Merged
merged 5 commits into from
Mar 23, 2023
Merged

Improved repository code quality #320

merged 5 commits into from
Mar 23, 2023

Conversation

Tansito
Copy link
Member

@Tansito Tansito commented Mar 22, 2023

Summary

Ref #307. This PR tries to use the same approach registering modules in the panel administrar as we are doing in gateway and the same validator in the artifact field.

Details and comments

  • Updated admin.py to use annotations instead of the method
  • Updated NestedProgram artifact field with tar extension validator

@Tansito Tansito requested review from IceKhan13 and pacomf March 22, 2023 15:34
@pacomf
Copy link
Member

pacomf commented Mar 22, 2023

@Tansito can you check the tests?

@Tansito Tansito merged commit f89674b into main Mar 23, 2023
@Tansito Tansito deleted the admin-registration branch March 23, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants