You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a dependency on django-allow-cidr so that we could configure ALLOWED_HOSTS to be internal services (i.e. from a 10. address). Also added a repository: "true" label for the repository pod(s) in order for the serviceMonitor to be able to scrape them.
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @psschwei I just left one doubt. Btw and just to confirm but this configuration that you are doing will need to be replicated in the gateway I assume. I created an issue about that: #374
this configuration that you are doing will need to be replicated in the gateway I assume
yeah, I think so
One thing I saw is that we're running the Django apps in debug mode (well, the repository is... didn't check the gateway). Debug mode will add localhost to the allowed hosts if allowed hosts is empty, which may be how it's accessible now in docker compose. But we should turn off debug mode in production, which means we'd have to probably give the allowed hosts a think or two...
One thing I saw is that we're running the Django apps in debug mode
Yes for repository and gateway. I didn't spend too much time yet preparing both applications for productions because including DEBUG we have the issue #315 too so I was thinking that they are stuff that it will happen at the same time (I can be wrong).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configuration to allow prometheus to scrape metrics from the repository
prereq for #368
Details and comments
Added a dependency on
django-allow-cidrso that we could configureALLOWED_HOSTSto be internal services (i.e. from a10.address). Also added arepository: "true"label for the repository pod(s) in order for the serviceMonitor to be able to scrape them.