Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Program rename #390

Merged
merged 58 commits into from
Apr 14, 2023
Merged

Program rename #390

merged 58 commits into from
Apr 14, 2023

Conversation

Tansito
Copy link
Member

@Tansito Tansito commented Mar 31, 2023 •
edited
Loading

Summary

Fix #386 , #342

Details and comments

@Tansito Tansito mentioned this pull request Mar 31, 2023
Merged
1 task
agarwal-aryan and others added 5 commits March 31, 2023 13:07
@agarwal-aryan
Updated Program.py (#347)
00310b7 
* Update program.py

Renameed Program to NestedProgram
Issue #342

* Revert "Update program.py"

* Update program.py

* Updated tests files as well

* Chnaged file name from program to nested_program

* Formatted files

* Changes Done

* Reformatted code

* Reformatted code

* NestedProgram to nested_program

* NestedProgram to nested_program

* NestedProgram to nested_program

* run_program to run_nested_program

* Done all the Changes

* Done all the Changes
@Tansito
Updated getting_started tutorials
49a8127
@Tansito
Updated guides
78cc36e
@Tansito
Updated guides
e9b6899
@Tansito
Updated index
d3e8d5c
@Tansito Tansito marked this pull request as ready for review March 31, 2023 14:46
@Tansito Tansito requested review from psschwei and pacomf March 31, 2023 15:02
@pacomf
Copy link
Member

pacomf commented Mar 31, 2023

Before merge @Tansito it can be great if you can double check that all tutorials/guide continue working properly, just in case...

psschwei
psschwei approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tansito
Copy link
Member Author

Tansito commented Apr 3, 2023 •
edited
Loading

Reviewing the code I just saw that I forgot to rename run_program in the Provider and in the Job. I just updated the references and the documentation. As soon as I finish reviewing the guides and the tutorials I merge it.

@Tansito Tansito mentioned this pull request Apr 4, 2023
Merged
@pacomf
Copy link
Member

pacomf commented Apr 4, 2023

We need to use QuantumFunction name now :)

pacomf
pacomf suggested changes Apr 4, 2023
View reviewed changes
Copy link
Member

@pacomf pacomf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QuantumFunction is the new name to refer Nested Program

@Tansito Tansito changed the title NestedProgram tutorials update QuantumFunction in favour of NestedProgram update Apr 5, 2023
@Tansito Tansito changed the title QuantumFunction in favour of NestedProgram update QuantumFunction rename Apr 5, 2023
Tansito added 19 commits April 13, 2023 11:50
@Tansito Tansito marked this pull request as ready for review April 13, 2023 12:01
@Tansito
Copy link
Member Author

Tansito commented Apr 13, 2023 •
edited
Loading

@IceKhan13 @pacomf I didn't change in this PR run_program. With the change of Program do we want to continue changing it or...?

psschwei
psschwei approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev environment builds locally, all getting started notebooks run, and didn't see any remaining nested_program or nestedprogram

@Tansito
Copy link
Member Author

Tansito commented Apr 13, 2023

@IceKhan13 @pacomf I didn't change in this PR run_program. With the change of Program do we want to continue changing it or...?

Created issue #435 to handle it in another PR

@Tansito Tansito merged commit 98825fd into main Apr 14, 2023
@Tansito Tansito deleted the nested-program-migration branch April 14, 2023 09:02
@psschwei psschwei mentioned this pull request Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei approved these changes

@pacomf pacomf pacomf approved these changes

@IceKhan13 IceKhan13 Awaiting requested review from IceKhan13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactorize NestedProgram with Program
6 participants
@Tansito @pacomf @jenglick @IceKhan13 @psschwei @agarwal-aryan