use postgresql as database for gateway and repository-server #508
Conversation
akihikokuroda
force-pushed
the
database
branch
4 times, most recently
from
49a287c to
4995db1
Compare
| }, | ||
| "root": { | ||
| "handlers": ["console"], | ||
| "level": "DEBUG", |
There was a problem hiding this comment.
We can open an issue and do it later but we should be able to modify the level of the LOGs through an environment variable, for example.
| } | ||
|
|
||
| if "test" in sys.argv: |
There was a problem hiding this comment.
Just as a doubt @akihikokuroda , now if we want to use sqlite what command do we need to use: python manage.py runserver test?
There was a problem hiding this comment.
It doesn't give the choice to use sqlite for runtime. It is for using the sqlite for the unit tests.
| initContainers: | ||
| - name: waitpostresql | ||
| image: actions/pg_isready | ||
| command: ['sh', '-c', 'until pg_isready -U {{ .Values.database.user | quote }} -d "dbname={{ .Values.database.name }}" -h {{ .Release.Name }}-postgresql -p {{ .Values.database.port | quote }}; do echo waiting for myservice; sleep 2; done'] |
There was a problem hiding this comment.
Correct me if I'm wrong @akihikokuroda , @psschwei but now from #505 we are not using or requiring the use of {{ .Release.Name }}, right?
There was a problem hiding this comment.
And thinking in loud. I would suggest to pass the host entirely as we are doing with the user and so on, I don't know what do you think (thinking that we are going to have the DBs outside the cluster, initially).
There was a problem hiding this comment.
by the way, won't it be required in this case the password?
There was a problem hiding this comment.
@Tansito Thanks for review. I made this change based on the main on Friday. I'll adjust the -h for the latest main.
The pg_isready doesn't need the password according to samples.
use SQLite for unit test Signed-off-by: Akihiko Kuroda <[email protected]>
| @@ -84,10 +84,16 @@ services: | |||
| - SITE_HOST=http://gateway:8000 | |||
| # - SETTINGS_AUTH_MECHANISM=default #custom_token | |||
| # - SETTINGS_TOKEN_AUTH_URL=<URL_FOR_TOKEN_VERIFICATION> | |||
There was a problem hiding this comment.
Just as a last comment @akihikokuroda I don't know if we can remove these lines commented if we are not going to need them.
There was a problem hiding this comment.
These lines were added in #524. I'll leave them there.
Summary
Fix #315
Details and comments