Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Redis in our helm configuration #95

Merged
merged 8 commits into from
Jan 5, 2023
Merged

Include Redis in our helm configuration #95

merged 8 commits into from
Jan 5, 2023

Conversation

Tansito
Copy link
Member

@Tansito Tansito commented Jan 4, 2023

Summary

Fix #84

This PR includes Redis in our helm configuration for future uses.

Details and comments

We add the Bitnami's Redis helm configuration to our dependencies.

Now the project can be built (we had problems with the versions but is fixed in this PR) and installed. The user can use all the configurations provided by Bitnami for redis but to simplify the initial setup I created a similar configuration that we have in the docker-compose.

Some changes that we are applying here:

  • The port for Redis will be the 7000 to avoid collisions with the port used by ray-dashboard.
  • Redis configuration is in standalone to simplify but the user can configure a replica if it wants.
  • The *.tgz from Redis is ignored by .gitignore (I was not totally sure about this decision or it we need to upload this file).

@Tansito Tansito requested a review from IceKhan13 January 4, 2023 18:05
@Tansito Tansito changed the title Included Redis in our helm configuration Include Redis in our helm configuration Jan 4, 2023
@Tansito Tansito requested a review from IceKhan13 January 5, 2023 10:03
@Tansito Tansito marked this pull request as draft January 5, 2023 12:24
@Tansito Tansito marked this pull request as ready for review January 5, 2023 14:00
Copy link
Member

@IceKhan13 IceKhan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Tansito Tansito added enhancement New feature or request and removed enhancement New feature or request labels Jan 5, 2023
@Tansito Tansito merged commit f46f74f into main Jan 5, 2023
@Tansito Tansito deleted the redis-chart branch January 5, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm: Add redis chart
2 participants