Skip to content

Commit

Permalink
Addressing review comments
Browse files Browse the repository at this point in the history
* Better naming variables
* Typos
  • Loading branch information
atilag committed Jul 28, 2018
1 parent 85e3cd4 commit f8fecb4
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions qiskit/backends/ibmq/ibmqjob.py
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ def queue_position(self):
Returns the position in the server queue
Returns:
Number: Position in the queue. 0 = No queued.
Number: Position in the queue. 0 = No queued yet
"""
return self._queue_position

Expand Down Expand Up @@ -549,25 +549,25 @@ def _numpy_type_converter(obj):

def _create_job_from_circuit(circuit):
""" Helper function that creates a special Job required by the API, from a circuit """
job = {}
api_job = {}
if not circuit.get('compiled_circuit_qasm', None):
compiled_circuit = transpile(circuit['circuit'])
circuit['compiled_circuit_qasm'] = compiled_circuit.qasm(qeflag=True)

if isinstance(circuit['compiled_circuit_qasm'], bytes):
job['qasm'] = circuit['compiled_circuit_qasm'].decode()
api_job['qasm'] = circuit['compiled_circuit_qasm'].decode()
else:
job['qasm'] = circuit['compiled_circuit_qasm']
api_job['qasm'] = circuit['compiled_circuit_qasm']

if circuit.get('name', None):
job['name'] = circuit['name']
api_job['name'] = circuit['name']

# convert numpy types for json serialization
compiled_circuit = json.loads(json.dumps(circuit['compiled_circuit'],
default=_numpy_type_converter))

job['metadata'] = {'compiled_circuit': compiled_circuit}
return job
api_job['metadata'] = {'compiled_circuit': compiled_circuit}
return api_job


def _is_job_queued(api_job):
Expand Down

0 comments on commit f8fecb4

Please sign in to comment.