Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latex circuit drawer needs a consistent visualization of cu1, crz, rzz #1957

Closed
ajavadia opened this issue Mar 12, 2019 · 5 comments · Fixed by #3155
Closed

latex circuit drawer needs a consistent visualization of cu1, crz, rzz #1957

ajavadia opened this issue Mar 12, 2019 · 5 comments · Fixed by #3155
Assignees
Labels
good first issue Good for newcomers

Comments

@ajavadia
Copy link
Member

What is the expected enhancement?

Let's make sure the text, mpl and latex drawer have a consistent representation for these.

There are some bugs, for example the latex doesn't draw rzz at all.

And there are some inconsistencies, for example mpl draws rzz as a line and text draws it as a box.

After discussions with @jaygambetta, let's do it like this:

circuit.cu1(0.8, q[0], q[1])
circuit.crz(0.7, q[0], q[1])
circuit.rzz(0.6, q[0], q[1])

q0_0: |0>─■─────────■──────■────
          │0.8 ┌────┴────┐ │zz(0.6)
q0_1: |0>─■────┤ Rz(0.7) ├─■────
               └─────────┘
q0_2: |0>───────────────────────

 c0_0: 0 ═══════════════════════

 c0_1: 0 ═══════════════════════

This just signifies that the 1st and 3rd gates are symmetric gates.

@1ucian0
Copy link
Member

1ucian0 commented Mar 12, 2019

#1960 fixes the text drawer.

@ajavadia ajavadia modified the milestone: 0.8 Apr 4, 2019
@1ucian0 1ucian0 changed the title need a consistent visualization of cu1, crz, rzz latex circuit drawer needs a consistent visualization of cu1, crz, rzz May 5, 2019
@1ucian0
Copy link
Member

1ucian0 commented May 5, 2019

At this point, this issue only affects the latex drawer. Renaming.

@ElisaGarijo
Copy link

@1ucian0 I am going to try to deep on this issue . OK?

@1ucian0
Copy link
Member

1ucian0 commented Aug 3, 2019 via email

@1ucian0 1ucian0 self-assigned this Aug 5, 2019
@1ucian0
Copy link
Member

1ucian0 commented Aug 18, 2019

any progress @ElisaGarijo ? Let me know!

brandhsn added a commit to brandhsn/qiskit-terra that referenced this issue Sep 26, 2019
brandhsn added a commit to brandhsn/qiskit-terra that referenced this issue Sep 26, 2019
1ucian0 pushed a commit that referenced this issue Sep 30, 2019
* Modified rzz visualization in latex circuit drawer to match the text/mpl drawer (#1957)

* added release note

* small release note fix
faisaldebouni pushed a commit to faisaldebouni/qiskit-terra that referenced this issue Aug 5, 2020
…it#3155)

* Modified rzz visualization in latex circuit drawer to match the text/mpl drawer (Qiskit#1957)

* added release note

* small release note fix
lcapelluto pushed a commit to lcapelluto/qiskit-terra that referenced this issue Sep 17, 2020
…it#3155)

* Modified rzz visualization in latex circuit drawer to match the text/mpl drawer (Qiskit#1957)

* added release note

* small release note fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants