Add Expr support to DAGCircuit.substitute_node_with_dag
#10381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelishman
added
the
Changelog: New Feature
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 5604497003
💛 - Coveralls |
Most of this was automatically upgraded during the switchover of `DAGCircuit.compose` to use the same general variable-remapping forms that `QuantumCircuit.compose` does. The remaining piece is to skip attempting to propagate the condition onto the subnodes; that is legacy behaviour from an old model of treating conditions as some "extra" to an operation, and not an inherent component of what was being applied.
jakelishman
force-pushed
the
expr/dag-substitite-dag
branch
from
0797e90 to
14c9dd2
Compare
|
Rebased on |
mtreinish
reviewed
Jul 19, 2023
mtreinish
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Most of this was automatically upgraded during the switchover of
DAGCircuit.composeto use the same general variable-remapping forms thatQuantumCircuit.composedoes. The remaining piece is to skip attempting to propagate the condition onto the subnodes; that is legacy behaviour from an old model of treating conditions as some "extra" to an operation, and not an inherent component of what was being applied.Details and comments
Resolve #10379. Depends on #10377.