Unify circuit drawer methods #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
nonhermitian and
taalexander
as code owners
|
The next step here will be to split out the latex drawer and matplotlib drawer into separate modules. |
mtreinish
force-pushed
the
reorg-circuit-drawer
branch
from
c386c8a to
df1c2ef
Compare
Merged
mtreinish
force-pushed
the
reorg-circuit-drawer
branch
from
df1c2ef to
0bd91d3
Compare
jaygambetta
previously approved these changes
Oct 8, 2018
As part of the cleanup of the circuit visualization module we really only need one entrypoint to draw a circuit. So instead of having 5 separate methods that all do the same thing with different mechanisms or options this commit condenses that all into the single circuit_drawer() method. 2 new kwarg flags are added to specify the output technique used and whether we should open the visualization in a new window after generating it. For backwards compatibility the old public methods still exist but are deprecated (which emits the proper warning) and can be removed after we include the warnings in a release and an appropriate period of time passes. Fixes Qiskit#1048 Fixes Qiskit#1049
mtreinish
force-pushed
the
reorg-circuit-drawer
branch
from
9850fa1 to
61b8899
Compare
jaygambetta
approved these changes
Oct 9, 2018
This was referenced Oct 10, 2018
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* Unify circuit drawer methods As part of the cleanup of the circuit visualization module we really only need one entrypoint to draw a circuit. So instead of having 5 separate methods that all do the same thing with different mechanisms or options this commit condenses that all into the single circuit_drawer() method. 2 new kwarg flags are added to specify the output technique used and whether we should open the visualization in a new window after generating it. For backwards compatibility the old public methods still exist but are deprecated (which emits the proper warning) and can be removed after we include the warnings in a release and an appropriate period of time passes. Fixes Qiskit#1048 Fixes Qiskit#1049 * Add changelog * Fix docstring lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As part of the cleanup of the circuit visualization module we really
only need one entrypoint to draw a circuit. So instead of having 5
separate methods that all do the same thing with different mechanisms or
options this commit condenses that all into the single circuit_drawer()
method. 2 new kwarg flags are added to specify the output technique used
and whether we should open the visualization in a new window after
generating it. For backwards compatibility the old public methods still
exist but are deprecated (which emits the proper warning) and can be
removed after we include the warnings in a release and an appropriate
period of time passes.
Details and comments
Fixes #1048
Fixes #1049