Deprecate the discrete pulse library #11110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the the following people are requested to review this:
|
1ucian0
reviewed
Oct 25, 2023
nkanazawa1989
added
Changelog: Deprecation
nkanazawa1989
approved these changes
Oct 26, 2023
| @@ -310,12 +310,12 @@ | |||
| "source": [ | |||
| "#### Pulse library functions\n", | |||
| "\n", | |||
| "Our own pulse library has sampling methods to build a `Waveform` from common functions." | |||
| "It is possible to convert `SymbolicPulse` objects into `Waveform`s via the `get_waveform()` method. Using our own pulse library you can build `Waveform` from common functions." | |||
There was a problem hiding this comment.
@nkanazawa1989 can you tell me if any (other) information in the Building Pulse Schedules tutorial is important to migrate to the Qiskit docs on IBM Quantum? I believe it will get lost otherwise with the big migration.
There was a problem hiding this comment.
I think new docs is largely based off of the existing Building Pulse Schedules tutorial so the rest of contents should be fine.
3 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Pull Request Test Coverage Report for Build 6681968128
💛 - Coveralls |
|
Given that this removal is planned for 1.0, we should backport the deprecation to 0.46. Thanks @TsafrirA for pointing it out. |
|
@Mergifyio backport stable/0.46 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
* Promote to deprecation and correct tests * remove `guassian` from tutorial * Release notes * change to 0.46.0 * Test fix * Lynt (cherry picked from commit 7c89b68)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 17, 2023
* Promote to deprecation and correct tests * remove `guassian` from tutorial * Release notes * change to 0.46.0 * Test fix * Lynt (cherry picked from commit 7c89b68) Co-authored-by: TsafrirA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
All pulses in the discrete pulse library now raise a
DeprecationWarning.Details and comments
#10222 started the deprecation process of the discrete pulse library, and now the
PendingDeprecationWarningare promoted toDeprecationWarning. Tests were updated accordingly.The tutorial 06_building_pulse_schedules.ipynb was updated in a very shallow way - the deprecated functions were removed, but the tutorial itself seems a bit stale. It requires some updates to the
SymbolicPulseera. This was beyond the scope of this PR.