Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow barriers in overlap circuit inputs #11179

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Allow barriers in overlap circuit inputs #11179

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5fae9a5
Allow barriers in overlap circuit inputs
caleb-johnson Nov 2, 2023
dddea0b
Minor fixes plus test with barriers
caleb-johnson Nov 6, 2023
3541831
Check parameter number on barrier test, similar to other non-failing …
caleb-johnson Nov 6, 2023
1192566
test order
caleb-johnson Nov 6, 2023
3386ed2
Add release note
caleb-johnson Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion qiskit/circuit/library/overlap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
from qiskit.circuit import QuantumCircuit, Gate
from qiskit.circuit.parametervector import ParameterVector
from qiskit.circuit.exceptions import CircuitError
from qiskit.circuit.library import Barrier
caleb-johnson marked this conversation as resolved.
Show resolved Hide resolved


class UnitaryOverlap(QuantumCircuit):
Expand Down Expand Up @@ -101,7 +102,7 @@ def _check_unitary(circuit):
"""Check a circuit is unitary by checking if all operations are of type ``Gate``."""

for instruction in circuit.data:
if not isinstance(instruction.operation, Gate):
if not isinstance(instruction.operation, [Gate, Barrier]):
caleb-johnson marked this conversation as resolved.
Show resolved Hide resolved
raise CircuitError(
(
"One or more instructions cannot be converted to"
Expand Down