Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve "Custom Pass Managers" docs #11288

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Improve "Custom Pass Managers" docs #11288

merged 3 commits into from
Nov 22, 2023

Conversation

kevinsung
Copy link
Contributor

@kevinsung kevinsung commented Nov 21, 2023 •
edited
Loading

Summary

  • Add missing import in code example
  • Replace the word "leverage" with "use"
  • Replace extraneous word "function" because it already shows up in the link.
  • Fix mix-up of "stage" and "pass manager"
  • Wording improvements.

Details and comments

@kevinsung kevinsung requested a review from a team as a code owner November 21, 2023 20:40
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@kevinsung kevinsung changed the title fix import in transpiler docs code example Improve "Custom Pass Managers" docs Nov 21, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6949411315

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 86.445%
Totals Coverage Status
Change from base Build 6946496347: 0.004%
Covered Lines: 66275
Relevant Lines: 76667
💛 - Coveralls

@mtreinish mtreinish added documentation Something is not clear or an error documentation Changelog: None Do not include in changelog labels Nov 21, 2023
@mtreinish mtreinish added this to the 0.45.1 milestone Nov 21, 2023
@mtreinish mtreinish added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Nov 21, 2023
@mtreinish mtreinish added this pull request to the merge queue Nov 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2023
@jakelishman jakelishman added this pull request to the merge queue Nov 21, 2023
Merged via the queue into Qiskit:main with commit 2935f0d Nov 22, 2023
mergify bot pushed a commit that referenced this pull request Nov 22, 2023
@kevinsung @mergify
Improve "Custom Pass Managers" docs (#11288)
9cbb997 
* fix import in transpiler docs code example

* other improvements

* fix stage <-> pass manager mix up

(cherry picked from commit 2935f0d)
@mergify mergify bot mentioned this pull request Nov 22, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 22, 2023
@mergify @kevinsung
Improve "Custom Pass Managers" docs (#11288) (#11291)
321c5e7 
* fix import in transpiler docs code example

* other improvements

* fix stage <-> pass manager mix up

(cherry picked from commit 2935f0d)

Co-authored-by: Kevin J. Sung <[email protected]>
@kevinsung kevinsung deleted the transpiler-docs branch November 22, 2023 04:09
FabianBrings pushed a commit to FabianBrings/qiskit that referenced this pull request Nov 27, 2023
@kevinsung @FabianBrings
Improve "Custom Pass Managers" docs (Qiskit#11288)
061f024 
* fix import in transpiler docs code example

* other improvements

* fix stage <-> pass manager mix up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
0.45.1
Development

Successfully merging this pull request may close these issues.
5 participants
@kevinsung @qiskit-bot @coveralls @mtreinish @jakelishman