Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve inverse cancellation docstring #11299

Merged
merged 1 commit into from
Nov 22, 2023
Merged

improve inverse cancellation docstring #11299

merged 1 commit into from
Nov 22, 2023

Conversation

kevinsung
Copy link
Contributor

Summary

  • Describe arguments
  • Document error more concisely

Details and comments

@kevinsung kevinsung requested a review from a team as a code owner November 22, 2023 17:01
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@mtreinish mtreinish added documentation Something is not clear or an error documentation Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable labels Nov 22, 2023
@mtreinish mtreinish enabled auto-merge November 22, 2023 17:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6960482503

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.009%) to 86.448%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 92.42%
crates/qasm2/src/parse.rs 6 97.13%
Totals Coverage Status
Change from base Build 6959799402: -0.009%
Covered Lines: 66277
Relevant Lines: 76667
💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Nov 22, 2023
Merged via the queue into Qiskit:main with commit 41b84b2 Nov 22, 2023
mergify bot pushed a commit that referenced this pull request Nov 22, 2023
@kevinsung @mergify
improve inverse cancellation docstring (#11299)
f5b1a0c 
(cherry picked from commit 41b84b2)
@mergify mergify bot mentioned this pull request Nov 22, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 23, 2023
@mergify @kevinsung
improve inverse cancellation docstring (#11299) (#11301)
5acb990 
(cherry picked from commit 41b84b2)

Co-authored-by: Kevin J. Sung <[email protected]>
@kevinsung kevinsung deleted the inverse-cancellation-docs branch November 24, 2023 00:45
FabianBrings pushed a commit to FabianBrings/qiskit that referenced this pull request Nov 27, 2023
@kevinsung @FabianBrings
improve inverse cancellation docstring (Qiskit#11299)
f13f560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinsung @qiskit-bot @coveralls @mtreinish