Fix broadcasting of QuantumCircuit.delay
#11447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The object is supposed to "broadcast" like a gate; one instruction per qubit. This silently did the wrong thing when given a `set` as its argument, previously.
jakelishman
added
stable backport potential
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7280573724
💛 - Coveralls |
mtreinish
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
This LGTM and seems straightforward enough. I do wonder if it's worth moving the gate broadcasting method to something more publicly reusable, but there also may not be a reason too because reusing the broadcasting logic outside of Gate might be sufficiently uncommon. Either way as a fix for backport this is good and minimal.
|
I've harped on about it before, but I think a fair amount of the "broadcasting" is quite broken and really ought to be removed, or localised to |
mergify bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
The object is supposed to "broadcast" like a gate; one instruction per qubit. This silently did the wrong thing when given a `set` as its argument, previously. (cherry picked from commit 4c6eed9) # Conflicts: # qiskit/circuit/quantumcircuit.py
jakelishman
added a commit
that referenced
this pull request
Jan 9, 2024
The object is supposed to "broadcast" like a gate; one instruction per qubit. This silently did the wrong thing when given a `set` as its argument, previously. (cherry picked from commit 4c6eed9)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
The object is supposed to "broadcast" like a gate; one instruction per qubit. This silently did the wrong thing when given a `set` as its argument, previously. (cherry picked from commit 4c6eed9) Co-authored-by: Jake Lishman <[email protected]>
ShellyGarion
pushed a commit
to ShellyGarion/qiskit-terra
that referenced
this pull request
Jan 18, 2024
The object is supposed to "broadcast" like a gate; one instruction per qubit. This silently did the wrong thing when given a `set` as its argument, previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The object is supposed to "broadcast" like a gate; one instruction per qubit. This silently did the wrong thing when given a
setas its argument, previously.Details and comments
Fix #11446.