-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect TeX #11599
Fix incorrect TeX #11599
Conversation
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7613582066Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these fixes. My only question is about the inner environment choice - if the .. math::
already counts as a displaymode entry, then I'd expect the best environment inside it to be aligned
, but if the backend wants the duplicated specification of displaymode, then fine.
0.45.2 is already released, so the milestone should have already been closed. We're not planning a 0.45.3 release, but assuming the documentation is decoupled from actual PyPI releases, we can still backport this to The CI failure was unrelated and fixed on main. |
Yep, we can build the docs from any CI artifact. So we only need it backported to stable/0.45. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
* fix tex * use aligned instead of align* --------- Co-authored-by: Eric Arellano <[email protected]> (cherry picked from commit 30bf727) # Conflicts: # qiskit/pulse/library/symbolic_pulses.py
* Fix incorrect TeX (#11599) * fix tex * use aligned instead of align* --------- Co-authored-by: Eric Arellano <[email protected]> (cherry picked from commit 30bf727) # Conflicts: # qiskit/pulse/library/symbolic_pulses.py * Fix merge conflict --------- Co-authored-by: Kevin J. Sung <[email protected]> Co-authored-by: Eric Arellano <[email protected]>
Summary
These bugs broke the internal docs build; see Qiskit/documentation#635.
Details and comments
align
environments.mbox
not defined