Deprecate visualization code #11636
Merged
Deprecate visualization code #11636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the the following people are requested to review this:
|
jakelishman
reviewed
Jan 31, 2024
Comment on lines
200
to
199
| @deprecate_arg("reverse_bits", since="0.22.0", package_name="qiskit-terra") | ||
| def get_bit_reg_index(circuit, bit, reverse_bits=None): | ||
| def get_bit_reg_index(circuit, bit): |
There was a problem hiding this comment.
These deprecations can stay in place through 0.46 - we'll remove everything in one fell swoop in 1.0 instead, because we're trying to keep 0.46 as close to being "0.45 with more warnings" as possible.
Since we're looking at them, it'd be good to include a removal_timeline="in the Qiskit 1.0 release" on all the deprecate_arg/deprecate_func calls in this PR.
jakelishman
added
Changelog: Deprecation
mtreinish
reviewed
Feb 1, 2024
releasenotes/notes/deprecate-visualization-code-8303626254b79abe.yaml
Outdated
Show resolved
Hide resolved
jakelishman
previously approved these changes
Feb 1, 2024
jakelishman
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following #10989, but for 0.46.
Details and comments
Set
pending=Falsefordataargument forplot_histogramincounts_visualization.py.Remove code and deprecation for
reverse_bitsarguments forget_bit_reg_indexandget_condition_label_valincircuit/_utils.py.