Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #11679

Merged
merged 2 commits into from
Jan 31, 2024
Merged

fix typo #11679

merged 2 commits into from
Jan 31, 2024

Conversation

kevinsung
Copy link
Contributor

Summary

Details and comments

@kevinsung kevinsung requested a review from mtreinish January 30, 2024 20:59
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@mtreinish mtreinish added documentation Something is not clear or an error documentation Changelog: None Do not include in changelog labels Jan 30, 2024
mtreinish
mtreinish approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching and fixing this

@mtreinish mtreinish enabled auto-merge January 30, 2024 21:27
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7717540673

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 89.565%
Files with Coverage Reduction New Missed Lines %
qiskit/synthesis/two_qubit/two_qubit_decompose.py 2 96.64%
crates/qasm2/src/lex.rs 5 91.69%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 7716964379: -0.02%
Covered Lines: 59607
Relevant Lines: 66552
💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Jan 30, 2024
Merged via the queue into Qiskit:main with commit 82f15d7 Jan 31, 2024
12 checks passed
@kevinsung kevinsung deleted the typo branch January 31, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

@alexanderivrii alexanderivrii Awaiting requested review from alexanderivrii

@ShellyGarion ShellyGarion Awaiting requested review from ShellyGarion

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinsung @qiskit-bot @coveralls @mtreinish