Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #11689

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fix typo #11689

merged 1 commit into from
Feb 1, 2024

Conversation

kevinsung
Copy link
Contributor

Summary

Details and comments

@kevinsung kevinsung requested a review from mtreinish January 31, 2024 16:35
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7729324752

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 89.607%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 91.94%
Totals Coverage Status
Change from base Build 7728099338: 0.03%
Covered Lines: 59334
Relevant Lines: 66216
💛 - Coveralls

jakelishman
jakelishman approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jakelishman jakelishman added documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Jan 31, 2024
@jakelishman jakelishman added this pull request to the merge queue Jan 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 1, 2024
@mtreinish mtreinish added this pull request to the merge queue Feb 1, 2024
@jakelishman jakelishman removed the stable backport potential The bug might be minimal and/or import enough to be port to stable label Feb 1, 2024
@jakelishman
Copy link
Member

I'll just remove the "stable backport label" and do it manually, since we're now in a weird interlude in the Mergify bot setup - it doesn't make sense to set it to stable/0.46, but also 1.0rc1 isn't out yet, so we can't set it to stable/1.0, and stable/0.45 is closed.

@jakelishman
Copy link
Member

@Mergifyio backport stable/0.46

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 1, 2024 •
edited
Loading

backport stable/0.46

✅ Backports have been created

Merged via the queue into Qiskit:main with commit 653b942 Feb 1, 2024
12 checks passed
mergify bot pushed a commit that referenced this pull request Feb 1, 2024
@kevinsung @mergify
fix typo (#11689)
82f8ff6 
(cherry picked from commit 653b942)

# Conflicts:
#	qiskit/transpiler/passes/synthesis/plugin.py
@mergify mergify bot mentioned this pull request Feb 1, 2024
Closed
@kevinsung kevinsung deleted the typo branch February 1, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

@mtreinish mtreinish Awaiting requested review from mtreinish

@alexanderivrii alexanderivrii Awaiting requested review from alexanderivrii

@ShellyGarion ShellyGarion Awaiting requested review from ShellyGarion

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kevinsung @qiskit-bot @coveralls @jakelishman @mtreinish