Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to black~=24.1 #11701

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Update to black~=24.1 #11701

merged 1 commit into from
Feb 1, 2024

Conversation

jakelishman
Copy link
Member

Summary

The new version of the black style launched a few days ago. We skipped 2023, but this updates us to use the 2024 style, which is mostly just a bit nicer around type-hints - several of the other more contentious changes got cut between the beta and the final release.

Details and comments

The new version of the `black` style launched a few days ago.  We
skipped 2023, but this updates us to use the 2024 style, which is mostly
just a bit nicer around type-hints - several of the other more
contentious changes got cut between the beta and the final release.
@jakelishman jakelishman added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Feb 1, 2024
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @enavarro51
  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia
  • @ikkoham
  • @levbishop
  • @mtreinish
  • @nkanazawa1989
  • @t-imamichi

Copy link
Contributor

@sbrandhsn sbrandhsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakelishman jakelishman enabled auto-merge February 1, 2024 09:58
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7739256861

  • -1 of 25 (96.0%) changed or added relevant lines in 15 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 89.351%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/visualization/state_visualization.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 6 91.44%
Totals Coverage Status
Change from base Build 7737347735: 0.02%
Covered Lines: 60176
Relevant Lines: 67348

💛 - Coveralls

@jakelishman jakelishman added this pull request to the merge queue Feb 1, 2024
Merged via the queue into Qiskit:main with commit 9aa2982 Feb 1, 2024
12 checks passed
@jakelishman jakelishman deleted the blacker branch February 1, 2024 11:47
jakelishman added a commit to jakelishman/qiskit-terra that referenced this pull request Feb 2, 2024
This adds commit 9aa2982 (Qiskitgh-11701) to the list of commits representing
automated formatting changes, so it can be ignored by `git blame`.
github-merge-queue bot pushed a commit that referenced this pull request Feb 2, 2024
This adds commit 9aa2982 (gh-11701) to the list of commits representing
automated formatting changes, so it can be ignored by `git blame`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants